upes-open / Placement-Manager

Placement-Manager is an open source Flask application used to managing and maintaining placement related data, activities, updates and more. Students can access their dashboard to update resume, information and other data while managers have access to administrative privileges for data handling, and student management.
GNU General Public License v3.0
9 stars 7 forks source link

potential code refactor and bug fixes #19

Closed tusharnankani closed 3 years ago

tusharnankani commented 3 years ago

The code could be refactored more, but I did not know if they would be required later. There were a few unused declared variables.

https://github.com/upes-open/Placement-Manager/blob/3dccc0f5c8976e0ac0529abd8cab71b2cc4ddb57/app.py#L77

https://github.com/upes-open/Placement-Manager/blob/3dccc0f5c8976e0ac0529abd8cab71b2cc4ddb57/app.py#L227

Also, this Expression not assigned.

https://github.com/upes-open/Placement-Manager/blob/3dccc0f5c8976e0ac0529abd8cab71b2cc4ddb57/spreadsheet.py#L41

Apart from this, let me know if any more changes are to be made.