search

upfrontsoftware / optimate

0 stars 0 forks source link

Clicking outside the slickgrid does not cause cell edits to save #217

Open nvernooy opened 8 years ago

nvernooy commented 8 years ago

If a cell is being edited in the slickgrid, and the user clicks anywhere outside the slickgrid, the cell does not update. This could be a problem in the order and valuation modals, where clicking save while still editing a cell could cause its data to be lost.

nvernooy commented 8 years ago

@rochecompaan what are your thoughts on this? Is this even an issue? I thought to automatically commit edits when the grid closes, but maybe the user intentionally wants to discard edits. Looking at firing a change event while the cell is being edited - https://github.com/mleibman/SlickGrid/issues/680 - seems like it could be hard to implement. Maybe something like a dialog telling the user there are unsaved edits.

Same goes for the project slickgrid, clicking away causes any uncommited edits to be lost.

rochecompaan commented 8 years ago

I think it might become and issue but at the moment I feel it is a very very small issue. Personally I use enter to ensure my values are committed and the visual feedback I get when the cursor moves to a new cell is enough to inform me that the change is persisted. Is there anyway to determine the slickgrid loses focus? I don't like the idea of firing a change event while the cell is being edited.

nvernooy commented 8 years ago

I don't think there's an easy way to tell when the grid loses focus, but committing cell changes manually is simple. Maybe the simplest would be to inform the user that there is unsaved work and leave it at that.