search

upgrades-migrations / preupgrade-assistant-modules

Modules for the Preupgrade Assistant tool. Disclaimer: It was fun. R.I.P. :-)
GNU General Public License v3.0
3 stars 11 forks source link

system/requirements: check dmidecode and dmesg before use #89

Closed pirat89 closed 6 years ago

pirat89 commented 6 years ago

Some architectures doesn't contain dmidecode utility at all and it does not have to be installed. So to suppress the error msg just check the utility exists. In addition I check even existence of the dmesg utility, however it should be installed always on the system as part of the util-linux-ng (on RHEL 6) which is required by the PA/PAM. ~From this point, there is possibly the dead code as the info from the /proc/meminfo file will be never used, but keeping that just to have seatbelts in case we would not get info from the dmesg.~

Additionaly one warning message has been removed, as it was irrelevant for the user (in 99.9% cases will not give any useful info for the user) and the error message has been lowered to warning as it was not an error (here it could gives useful info in some cases, but usually you will not see the message at all).

Fixes: #40

AloisMahdal commented 6 years ago

qa_ack: re-run at least some upgrade tests on s390x and ppc64. There used to be always stderr line in report (/CoreOS/preupgrade-assistant-el6toel7/smoke/upgrade will catch it for sure).

AloisMahdal commented 6 years ago

OK, so testing with preupgrade-assistant-el6toel7-0.7.4-0.201806041927Z.PR89.el6_8.noarch:

pirat89 commented 6 years ago

Great work! thanks :)