search

upgrades-migrations / preupgrade-assistant-modules

Modules for the Preupgrade Assistant tool. Disclaimer: It was fun. R.I.P. :-)
GNU General Public License v3.0
3 stars 11 forks source link

system/pam #96

Closed jmazanek closed 6 years ago

jmazanek commented 6 years ago
jmazanek commented 6 years ago

How to test:

  1. In one or more of the configuration files in /etc/pam.d/ directory, add the one or more deprecated directives (pam_passwdqc|pam_ecryptfs) example: password required pam_passwdqc.so

  2. Run the p-a modules with this fix.

  3. Results should be needs_inspection if only pam_passwdqc directive is present, needs_action if both or only pam_ecryptfs and pass otherwise. Configuration files with deprecated directives commented out will be copied into /root/preupgrade/cleanconf/etc/pam.d/.

jmazanek commented 6 years ago

Subdirectory should not, to my knowledge appear there. This line in the code should ensure, that inputs are just ordinary files for file in $(find -P /etc/pam.d/ -maxdepth 1 -type f)

AloisMahdal commented 6 years ago

qa_ack: test according to description from @jmazanek

tcerna commented 6 years ago

New test case was written for this PR96: preupgrade-assistant-el6toel7/ast/pam-deprecated-directives

Test passed in preupgrade-assistant-el6toel7-0.7.5-0.201807021157Z.PR96.el6_8.noarch -> VERIFIED