search

upgrades-migrations / preupgrade-assistant-modules

Modules for the Preupgrade Assistant tool. Disclaimer: It was fun. R.I.P. :-)
GNU General Public License v3.0
3 stars 11 forks source link

system/BinariesRebuild #97

Closed jmazanek closed 6 years ago

jmazanek commented 6 years ago
jmazanek commented 6 years ago

This fix tests if the argument to gen_blacklist function is not empty, before passing it to test if it is an existing file. The strange quotation format on the second line is internal to the error message, that seems to be produced by ldd command when missing the expected library.

jmazanek commented 6 years ago

How to test:

  1. In /etc/preupgrade-assistant.conf add a following input:

    [xccdf_preupg_rule_system_BinariesRebuild_check] exclude_file=

  2. Run the preupgrade-assistant , the warning message for the missing file should not be printed

  3. As a control case, put a value to exclude_file directive to some non-existing file. In this case the warning message will be printed.

tcerna commented 6 years ago

New test case for this PR created: /CoreOS/preupgrade-assistant-el6toel7/ast/binaries-rebuild-checks-exclude-file-directive

Test case passed with installed preupgrade-assistant-el6toel7-0.7.5-0.201807030924Z.PR97.el6_8.noarch -> VERIFIED