Remove unused/obsolete get_upgrade_dir_path()

upgrades-migrations / preupgrade-assistant

The Preupgrade Assistant performs an assessment of the system from the "upgradeability" point of view. Disclaimer: It was fun. R.I.P. :-)

GNU General Public License v3.0

13 stars 15 forks source link

Closed bocekm closed 7 years ago

bocekm commented 7 years ago

This method:

is dead/not used code
obsolete because the module set dir is retrieved by application.py method _get_default_module_set()

AloisMahdal commented 7 years ago

qa_ack: re-running downstream preupg test suite should be fine.

AloisMahdal commented 7 years ago

This is based on very old code, which is not compatible with downstream test suite; please rebase.

bocekm commented 7 years ago

@AloisMahdal, rebased.

AloisMahdal commented 7 years ago

Thanks, verified with preupgrade-assistant-2.5.0-0.201710190759Z.PR323.el6_8. Whole test suite passed.

bocekm commented 7 years ago

Thanks, @AloisMahdal. @pirat89, re-review the PR again please, your review has been dismissed due to the rebase.