uphold / docker-litecoin-core

MIT License
53 stars 44 forks source link

Dockerfile not verifying checksum of downloaded tarball #24

Closed DavidHoude closed 4 years ago

DavidHoude commented 4 years ago

The Dockerfile is downloading the checksum file, and verifying the signature via Litecoin's public keys, but is not verifying that the checksum of the tarball matches. I have added a line to compare the checksum to what is listed in the file.

https://github.com/uphold/docker-litecoin-core/pull/23/files

DavidHoude commented 4 years ago

This was closed due to me thinking I was missing someting, ended up testing a PoC and verifying the issue is legit. I have created a new issue and new PR to ensure the issue was described more concisely, and flattened the multiple commits that had typos to ensure there was no confusion.

Issue: https://github.com/uphold/docker-litecoin-core/issues/25 Pull Request: https://github.com/uphold/docker-litecoin-core/pull/26