search

uphold / docs

Uphold API Reference
https://uphold.com/en/developer/api/documentation/
48 stars 39 forks source link

Update cards and addresses #155

Closed rplopes closed 6 years ago

rplopes commented 6 years ago

Add normalized and settings.protected to cards. Fix addresses formatting.

rplopes commented 6 years ago

I generally agree with the goal of keeping diffs small between commits. However, since the fix here was to replace the existing example with an updated API output, it feels like there's not a lot we could split and still get atomic, correct commits. We could reorder the old example to match the new example's order, to help with diff'ing later, but that's about it.

The content of the fields didn't necessarily have to change. It did just to keep consistent with e.g. the new rates, the new fields, and so on. Since these PRs update cards, transactions and so on, which are dependent on each other, it seemed like an improvement to have examples that make sense between these different entities.

waldyrious commented 6 years ago

Ok, thanks for clarifying. I understand that it's not always possible / reasonable to maximize commit atomicity; I just wanted to make sure that it was a considered decision rather than a general practice.