uphold / docs

Uphold API Reference
https://uphold.com/en/developer/api/documentation/
48 stars 39 forks source link

Card settings vs position #20

Closed naps62 closed 9 years ago

naps62 commented 9 years ago

The documents state that a card entity has a position attribute. But instead, the current JSON I'm getting has a settings attribute, which in turn has position and starred

Which one of these is the correct one?

jrpereira commented 9 years ago

The position is within the settings attribute, it's a documentation mismatch, needs to be corrected.

Feel free to send a PR to fix any documentation issues you find or if you have any suggestions for clarity!

naps62 commented 9 years ago

Sure, I can do that. I just had to be sure of which was the outdated one, the docs or the API

nunorafaelrocha commented 9 years ago

I've just submitted a PR to fix the documentation about this issue.