uphold / uphold-sdk-javascript

Uphold SDK for JavaScript
https://uphold.github.io/uphold-sdk-javascript
MIT License
84 stars 28 forks source link

How does the SDK work for the browser? #62

Open hrgui opened 3 years ago

hrgui commented 3 years ago

Description

In the README.md, it states that this SDK works in the browser.

Supported platforms This SDK can be used on both browser and Node.js environments.

However, it requires a client_id and client_secret.

As per https://uphold.com/en/developer/api/documentation/#registering-an-application:

Security Notice: Your Client Secret should never be shared, must be kept secret at all times and should only be used from your server-side application.

Using it in the browser can potentially expose the client ID and client secret through the JavaScript files. This contradicts how this can be used in the browser - unless I am missing something?

Is there any examples that use this SDK in a browser-based way?