search

uphy / joplin-plantuml-plugin

18 stars 1 forks source link

Data is sent unencyrpted to plantuml.com #2

Open renestalder opened 3 years ago

renestalder commented 3 years ago

I feel like the plugin requires a disclaimer, that plantuml.com service is used in the background to generate images of the PlantUML data. That means, data is sent unencrypted to an external service and can be read by it.

Or I guess there is a way to let the plugin generate the images without an external service.

marc0l92 commented 3 years ago

Is it possible to add a setting to change the rendering server? In this way I can use the one of the company or a docker image running on my machine

renestalder commented 3 years ago

Based on the code, that is probably an addition that doesn't take much effort apart from adding the settings menu or panel, as the markdownit plantuml dependency has a parameter for setting the server.

Full offline support would probably also be doable with node-plantuml

uphy commented 3 years ago

Thank you for the suggestion. I have also tried to add the setting but unfortunately it's not possible now: https://discourse.joplinapp.org/t/how-can-i-refer-the-plugin-settings-from-contentscript/15354/4

After Joplin support to refer settings from content script, I will implement it.