search

uphy / obsidian-reminder

Reminder plugin for Obsidian
https://uphy.github.io/obsidian-reminder/
MIT License
457 stars 35 forks source link

[Bug]: Calendar pop-up does not work on mobile devices #34

Closed richardlm closed 3 years ago

richardlm commented 3 years ago

Describe the bug

The calendar popup does not work on Android, even if I set the trigger text to something simple.

Expected Behavior

Setting trigger text such as xxxxx works on Obsidian desktop but not Android.

Steps to reproduce

On Android: Configure Reminder to work with Tasks Set trigger text to xxxxx Create a reminder and enter xxxxx

Operating system

Android

davebhc71 commented 3 years ago

Isn’t working at all on iPad. Is that a known issue that I missed somewhere?

uphy commented 3 years ago

Calendar popup seems to be implemented using an API that doesn't work on mobile devices.

Further research is needed on how to implement it, and it will take some time to resolve.

davebhc71 commented 3 years ago

Thanks for reply. Shame the current method doesn’t work on Mobile Devices. How about if you ‘called’ the Calendar pop-up from a Hotkey????

On Nov 1, 2021, at 9:12 PM, Yuhi Ishikura @.***> wrote:

 Calendar popup seems to be implemented using an API that doesn't work on mobile devices.

https://github.com/uphy/obsidian-reminder/blob/68d9cc50da7ddba137249a5e6baec0749f36686b/src/main.ts#L81-L94 https://github.com/uphy/obsidian-reminder/blob/68d9cc50da7ddba137249a5e6baec0749f36686b/src/ui/datetime-chooser.ts#L50 Further research is needed on how to implement it, and it will take some time to resolve.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

uphy commented 3 years ago

It's same. Calendar popup from a hotkey also use APIs not work in mobile devices.

uphy commented 3 years ago

For mobile, I gave up on popup triggered by input text. Instead, as you said, I'm implementing with a command to show the calendar popup.

Kapture 2021-11-02 at 21 20 41

davebhc71 commented 3 years ago

GREAT!!! Looking forward to it!!

On Nov 2, 2021, at 8:22 AM, Yuhi Ishikura @.***> wrote:

 For mobile, I gave up on popup triggered by input text. Instead, as you said, I'm implementing with a command to show the calendar popup.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

uphy commented 3 years ago

@davebhc71 @richardlm Mobile support for calendar popup is available in v1.1.3.

It is useful to register the command as a toolbar button as shown in the video above.

  1. Options > Mobile
  2. Configure
  3. Select the command named Show calendar popup
davebhc71 commented 3 years ago

There was no “video above” to register the Command as a Toolbar button in the email I received. I’ve tried to use the instructions 1,2, and 3, but there is no “Show Calendar Popup”

Davebhc71

On Nov 3, 2021, at 12:10 AM, Yuhi Ishikura @.***> wrote:

 @davebhc71 @richardlm Mobile support for calendar popup is available in v1.1.3.

It is useful to register the command as a toolbar button as shown in the video above.

Options > Mobile Configure Select the command named Show calendar popup — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

davebhc71 commented 3 years ago

  Ignore my previous email. I was able to Configure Mobile Quick Action with the Show Calendar Popup BUT I don’t think that’s the most convenient/ proper place for it to appear. I would much prefer to have it as one of the options the Mobile Tool Bar that is always visible above the keyboard. Just a suggestion!

Davebhc71

On Nov 3, 2021, at 12:10 AM, Yuhi Ishikura @.***> wrote:  @davebhc71 @richardlm Mobile support for calendar popup is available in v1.1.3.

It is useful to register the command as a toolbar button as shown in the video above.

Options > Mobile Configure Select the command named Show calendar popup — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

davebhc71 commented 3 years ago

Never Mind …….. I was able to ADD it to the Command Palette! Sorry for the confusion. Works like a charm. Thanks for your work!

Davebhc71

On Nov 3, 2021, at 12:10 AM, Yuhi Ishikura @.***> wrote:

 @davebhc71 @richardlm Mobile support for calendar popup is available in v1.1.3.

It is useful to register the command as a toolbar button as shown in the video above.

Options > Mobile Configure Select the command named Show calendar popup — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

uphy commented 3 years ago

Thank you for your report! I close this issue.