uphy / obsidian-reminder

Reminder plugin for Obsidian
https://uphy.github.io/obsidian-reminder/
MIT License
440 stars 34 forks source link

[Bug]: Calendar is not setting the date inline #51

Open ealdaon opened 2 years ago

ealdaon commented 2 years ago

Describe the bug

The calendar is popping out correctly but it doesn't write the date inline when is selected: image

image

The workaround is type the date manually but is not desired.

This doesn't happen in a new vault but after uninstall and clear the folder in the .obsidian path, it's not working either, and seems like more people is affected (at least 1 more reported this in the Obsidian's Discord).

Expected Behavior

Pick a date and automatically set inline.

Steps to reproduce

Just type the calendar trigger and select a date.

Operating system

Windows

ealdaon commented 2 years ago

Hi again, i find out that it works disabling the live preview.

uphy commented 2 years ago

Can you upload error log from Developer Tools?

gnuwind commented 2 years ago

hi @uphy

I have the same problem. The Developer Tools error message is as follows: image

The first error occurs when the calendar selector appears, and the second error occurs after I select the date.

Version Obsidian: 0.13.21 Reminder: 1.1.4

baofeidyz commented 2 years ago

same bug as me when using live preview

dcoales commented 2 years ago

Same here with live preview. I get the same error when the picker opens i.e.

Error: Calls to EditorView.update are not allowed while an update is in progress
    at t.update (app.js:1)
    at t._dispatch (app.js:1)
    at t.dispatch (app.js:1)
    at Object.blur (app.js:1)
    at t.runCustomHandlers (app.js:1)
    at HTMLDivElement.<anonymous> (app.js:1)
    at DateTimeChooserModal.t.open (app.js:1)
    at eval (eval at <anonymous> (app.js:1), <anonymous>:20213:15)

But a slightly different error when the date is selected i.e.

RangeError: Trying to update state with a transaction that doesn't start from the previous state.
    at t.update (app.js:1)
    at eval (eval at <anonymous> (app.js:1), <anonymous>:20426:41)
uphy commented 2 years ago

I could reproduced the following issue with Admotion plugin.

RangeError: Trying to update state with a transaction that doesn't start from the previous state.
    at t.update (app.js:1)
    at eval (eval at <anonymous> (app.js:1), <anonymous>:20426:41)

It is fixed (as a workaround though...) in v1.1.5.

But the first one Error: Calls to EditorView.update are not allowed while an update is in progress was not reproduced. Can you try to find out the condition of this issue? (Which plugin causes, ...) One possible cause, I'm using Obsidian v0.13.19.

ghanan commented 2 years ago

I have the same problem when selecting date from de popup calendar and when I write de date manually it does not work either. Even after executing a manual "Scan reminders" they don't appear in the side panel. I am in Manjaro with Obsidian 0.13.30 and Reminder 1.1.8

uphy commented 2 years ago

@ghanan Can you upload error log? You can get it from Developer Tools. I'm using Obsidian 0.13.30 on macOS BigSur but it doesn't reproduce.

ghanan commented 2 years ago

I think they are similar errors than others already posted, but here they are: First error, when I write (@ and the calendar appears:

Error: Calls to EditorView.update are not allowed while an update is in progress
    at e.update (app.js:1)
    at e._dispatch (app.js:1)
    at e.dispatch (app.js:1)
    at Object.blur (app.js:1)
    at e.runCustomHandlers (app.js:1)
    at HTMLDivElement.<anonymous> (app.js:1)
    at DateTimeChooserModal.e.open (app.js:1)
    at eval (eval at <anonymous> (app.js:1), <anonymous>:20272:15)
    at new Promise (<anonymous>)
    at showDateTimeChooserModal (eval at <anonymous> (app.js:1),
<anonymous>:20270:12)
Ks                          @   app.js:1
e.runCustomHandlers         @   app.js:1
(anonymous)                 @   app.js:1
e.open                          @   app.js:1
eval                            @   date-chooser-modal.ts:79
showDateTimeChooserModal    @   date-chooser-modal.ts:77
eval                            @   editor-extension.ts:23
Yi                          @   app.js:1
t.iterChanges                   @   app.js:1
update                          @   editor-extension.ts:15
e.update                    @   app.js:1
e.updatePlugins                 @   app.js:1
e.update                    @   app.js:1
_dispatch                   @   app.js:1
e.dispatch                  @   app.js:1
ec                          @   app.js:1
(anonymous)                 @   app.js:1
e.flush                         @   app.js:1
(anonymous)                 @   app.js:1

and when I click in a date, the error:

Cannot append reminder time to the line: line=Test-line (@), date=DateTime$2
eval                @   editor-extension.ts:32
Promise.then (async)        
eval                @   editor-extension.ts:23
Yi              @   app.js:1
t.iterChanges       @   app.js:1
update              @   editor-extension.ts:15
e.update        @   app.js:1
e.updatePlugins     @   app.js:1
e.update        @   app.js:1
_dispatch       @   app.js:1
e.dispatch      @   app.js:1
ec              @   app.js:1
(anonymous)     @   app.js:1
e.flush             @   app.js:1
(anonymous)     @   app.js:1
IvanCodeslol commented 1 year ago

Hi. I, too, get the same error:

Cannot append reminder time to the line: line=(@, date=2022-12-05

OS: Linux Obsidian version: 1.0.3 Reminder version: 1.1.15

ghanan commented 1 year ago

Just in case, be sure the line is a check line, i.e. it starts with "- [ ]"

IvanCodeslol commented 1 year ago

Well, that's weird, it works fine if it's in a check line.

naive231 commented 1 year ago

Same bug remains. Obsidian: 1.3.5 Reminder: 1.1.15

joiellantero commented 11 months ago

I'm experiencing the original bug stated above

Obsidian error log: Screenshot 2023-12-05 at 2 28 30 AM

Obsidian version: v1.4.16 Reminder version: v1.1.15 Operating System: MacOs Sonoma v14.1.2

joiellantero commented 11 months ago

I'm experiencing the original bug stated above

Obsidian error log: Screenshot 2023-12-05 at 2 28 30 AM

Obsidian version: v1.4.16 Reminder version: v1.1.15 Operating System: MacOs Sonoma v14.1.2

Bug was gone after downloading the Task plugin and turning on the Task plugin settings that is located in the Reminder's plugin settings. Screenshot 2023-12-05 at 2 52 07 AM