upiterbarg / mpmath

Automatically exported from code.google.com/p/mpmath
Other
0 stars 0 forks source link

setup.py lacks shebang #37

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
$ ./setup.py install      
./setup.py: line 1: from: command not found                    
: command not found                                            
'/setup.py: line 3: syntax error near unexpected token `name='mpmath',
'/setup.py: line 3: `setup(name='mpmath',                             
$ python setup.py install
running install                                               
running build                                                 
running build_py 
[...]                               

This is trivial, simple #!python in the first line would do the job.

Original issue reported on code.google.com by Vinzent.Steinberg@gmail.com on 23 Apr 2008 at 2:23

GoogleCodeExporter commented 9 years ago
runtests.py is affected too.

Original comment by Vinzent.Steinberg@gmail.com on 23 Apr 2008 at 5:11

GoogleCodeExporter commented 9 years ago
Added. Let me know if it works.

Original comment by fredrik....@gmail.com on 23 Apr 2008 at 7:52

GoogleCodeExporter commented 9 years ago
It doesn't work for some reason, please change it to the more conservative 
approach:

#!/usr/bin/env python

This time I tested it to be sure. Sorry, I should have done this before.

Original comment by Vinzent.Steinberg@gmail.com on 25 Apr 2008 at 12:28

GoogleCodeExporter commented 9 years ago
Fixed. Please check again :)

Original comment by fredrik....@gmail.com on 25 Apr 2008 at 2:20

GoogleCodeExporter commented 9 years ago
Sadly it doesn't work one Linux probably due to Windows line endings. But I 
don't 
expect you to change line endings to Unix encoding. Just leave it as it is 
(anyone 
can convert the line endings easily if he needs or just use python setup.py) 
and 
thanks for adding the shebangs.

Original comment by Vinzent.Steinberg@gmail.com on 1 May 2008 at 2:24

GoogleCodeExporter commented 9 years ago
Yeah, the line endings issues are annoying. But it seems to me that unix line 
endings
kind of work everywhere, don't they?

Original comment by ondrej.c...@gmail.com on 1 May 2008 at 10:00

GoogleCodeExporter commented 9 years ago
Yes, but not all Windows editors support them. Notepad for example. I don't 
which
editor Fredrik is using (surely not Notepad :), and this issue is very very 
minor. I
don't know if it's worth it to swap to unix line endings. Every good editor can
handle all kinds of line endings though.

Original comment by Vinzent.Steinberg@gmail.com on 2 May 2008 at 9:09

GoogleCodeExporter commented 9 years ago
We have exactly the same problem with sympy, or any other project. Imho one 
just has
to choose one way and stick to that. And fix all problems with it.

Original comment by ondrej.c...@gmail.com on 2 May 2008 at 12:08

GoogleCodeExporter commented 9 years ago
My editor supports unix line endings. I haven't thought of making this the 
default,
but I guess I should.

Original comment by fredrik....@gmail.com on 2 May 2008 at 4:38