search

upkarlidder / cp-tipcalc-1

CodePath Tip Calculator
0 stars 0 forks source link

Review my app - Upkar #1

Open upkarlidder opened 11 years ago

upkarlidder commented 11 years ago

The tip calculator is complete as per the assignment specs. Please review and provide feedback. Thank you both. /cc @nesquena @timothy1ee

nesquena commented 11 years ago

Few positive notes:

Looks good did you have any other questions about the assignment or anything? Hopefully helped reinforce a lot of the key concepts. Next week the project will build on the basics here but ramp up to include networking (with APIs), image handling and more. See you tomorrow.

upkarlidder commented 11 years ago

Thank you Nathan. Looking forward to the class tonight.

Upkar.

On 2013-08-25, at 4:42 PM, Nathan Esquenazi notifications@github.com wrote:

Few positive notes:

Good layout, proper view naming, usage of sp/dp, margin and relative placement rules. Handled the click handling properly using onclick flag and then differentiating based on the button id Did error handling for empty cases Properly formatted the result Looks good did you have any other questions about the assignment or anything? Hopefully helped reinforce a lot of the key concepts. Next week the project will build on the basics here but ramp up to include networking (with APIs), image handling and more. See you tomorrow.

— Reply to this email directly or view it on GitHub.