upkarlidder / ios-rotten-tomatoes-app

1 stars 1 forks source link

Rotten Tomatoes Submission #1

Open upkarlidder opened 10 years ago

upkarlidder commented 10 years ago

Hi @nesquena and @timothy1ee. Please review. I finished the base use cases and added

upkarlidder commented 10 years ago

Hi @nesquena and @timothy1ee. I copied the .gitignore file from stackoverflow. I tried cloning the project and running in xcode, it failed. So I have removed the .gitignore file for now. I can clone and it works. I still have to open the xcworkspace to get the pods working. Let me know if it does not work. Thank you.

timothy1ee commented 10 years ago

Good job and excellent readme! The clone probably failed because it ignores Pods, which some people do, including the GitHub Objective-C .gitignore template. It just means that you have to run pod install after cloning. However, the CocoPods team actually recommends that you NOT ignore the Pods directory. I use the GitHub .gitignore template, but I check in my pods for convenience.

The point of this homework was to explore a simple example of a full MVC application with a RESTful API. When I'm auditing the code, I use the checklist below. If you didn't do one of the items below, you should consider implementing it.