Open upkarlidder opened 11 years ago
I don't have my name set up with the github Account. Upkar Here.
:+1: Hey Upkar, looks good. A few points of feedback:
asyncGetImages
for both initial load and the paginationSearchFilters.java
) representing all the filters which was passed back and forth in the activities in the bundleLet us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be very important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
Thank you Nathan. Will pursue your feedback.
One thing I am concerned about is the look and feel. This app seems old school compared to a production app on google store. I guess people use graphics designer to create nicer images.
I definitely have a new found appreciation for professional app developers. There is a lot that goes into creating even a simple app like this. Lots of use cases and scenarios.
Upkar.
On 2013-09-03, at 10:13 PM, Nathan Esquenazi notifications@github.com wrote:
Hey Upkar, looks good. A few points of feedback:
Proper layout naming, uses relative layouts, string resources, etc Properly reused the same method asyncGetImages for both initial load and the pagination "Next" and "Previous" buttons which allow image pagination by shifting index Just a little polish note but might have considered using a ProgressBar to display when async requests start Properly used inputs to allow users to select values Nice work using preferences to persist the filters based on selected input values One thing to consider is rather than sending and returning all the filter values separately in the intent result as keys, might have introduced a serializable model (i.e SearchFilters.java) representing all the filters which was passed back and forth in the activities in the bundle Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be very important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
— Reply to this email directly or view it on GitHub.
Yes, you bring up good points. The app UI for the early apps (and most of the apps in this class) are not particularly polished or modern by any means. Yes, part of it is having graphics designers create image assets and another aspect is just subtle UI polish and finish that goes into production apps. Absolutely there is a lot involved in creating apps with even basic UI/UX flows. And a lot more in creating a highly modern, customized and polished experience.
It's a common saying that the last 20% (polish, details, refinement) of a production app often takes more time than the first 80%. That's why a first prototype can be built in a couple weeks but a fully finished product that feels polished can often take months.
For now, as we get familiar with the basic constructs and patterns, it's not as important that the apps are highly polished or have modern UIs although the later projects slowly ramp up in that regard.
The gridsearch app is complete. Please review. README.md contains the details. /cc @nesquena @timothy1ee