upkarlidder / twitterclone

0 stars 0 forks source link

Finished twitter redux #2

Open upkarlidder opened 11 years ago

upkarlidder commented 11 years ago

Hello Nathan and Tim. I have finished the bare minimum for this hw (as per the pdf). Sorry, I did not have enough time to make changes suggested by you in the last submit. I will have to come back to this after our group project. Thank you both for your support and help. /cc @nesquena @timothy1ee

nesquena commented 11 years ago

Hi Upkar, as you mentioned project is somewhat incomplete, here's more detailed feedback:

Despite this being incomplete, hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, .

Today (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.

Week 7 (Sept 30th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group apps that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.

upkarlidder commented 11 years ago

Hello Nathan,

Thank you for the detailed feedback. The goal is to turn this into a better twitter app within a month after finishing the class with all of your feedback. Even though the app is buggy and incomplete, I do understand the various components of the application and can definitely take a stab at developing an android client from scratch.

See you tonight, Upkar.

On 2013-09-18, at 1:56 PM, Nathan Esquenazi notifications@github.com wrote:

Hi Upkar, as you mentioned project is somewhat incomplete, here's more detailed feedback:

Used FrameLayout to act as a container for timeline tab content Probably should rename the "activity_time_line.xml" to "fragment_timeline.xml" for clarity Setup ActionBar Tabs mode with the Home and Mentions timeline tabs With ActionBarSherlock and with proper SherlockTabListener approach MISSING: No base fragment for timelines means tons of duplication Next step is to build a base fragment and move as much of the shared code as possible to there Also fragments should probably be kept in a sub-package namespace (i.e com.codepath.upkar.twitterapp.fragments) Tons of duplication with home, mention and profile timelines Setup endless pagination that works in home timeline (but not in profile) Properly setup user profile view with profile header and a user timeline fragment Can view my profile by clicking on the ActionBar MISSING: When I click on a user's image it doesn't take me to their profile BUG: When I compose a tweet, I don't see it in the home timeline BUG: When I hit compose, I see your username instead of my own (yours is hardcoded in compose view) Despite this being incomplete, hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, .

Today (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.

Week 7 (Sept 30th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group apps that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.

— Reply to this email directly or view it on GitHub.