upkie / vulp

Robot/simulation switch for the mjbots stack
Apache License 2.0
61 stars 4 forks source link

Warn when logging buffer is full #103

Closed stephane-caron closed 1 week ago

stephane-caron commented 1 month ago

As discussed with @ubgk today, currently we don't check that logging succeeds at every spine cycle:

https://github.com/upkie/vulp/blob/af23b129c0e6cfc0d851b1ef96860929c0139bc5/vulp/spine/Spine.cpp#L72

The output from mpacklog::Logger::put is a success boolean. When it fails we should warn users that some log entries are being lost. (Perhaps suggest follow-up actions such as (1) increasing the size of the circular buffer or (2) reducing the size of logged dictionaries.)