search

upkie / vulp

Robot/simulation switch for the mjbots stack
Apache License 2.0
61 stars 4 forks source link

macOS compatibility #16

Closed ubgk closed 1 year ago

ubgk commented 1 year ago

So far, I've tried to make the code base macOS compatible by wrapping all Linux specific code or header inclusions with guards: https://github.com/tasts-robots/vulp/pull/15.

The build succeeds with tools/bazelisk build //....

Tests fail, however, when I do tools/baselisk test //.... I've attached the logs, but I'm not sure how to interpret them. test_fail.log

stephane-caron commented 1 year ago

Thanks @boragokbakan for keeping this issue updated. If I understand correctly you closed it following https://github.com/tasts-robots/vulp/pull/15#discussion_r1200644848?

Since the PR hasn't been merged yet, a better practice is to keep the issue open and link it from the PR using the "Development" section to the right of the PR page:

Or writing "Closes #issue_number" in a commit to the corresponding branch (even better, since then we log exactly which commit solves the issue).

ubgk commented 1 year ago

Thanks for your reply @stephane-caron.

I created a new issue, so this one felt redundant (and too broad). I didn't mean to imply it's "solved", sorry for the confusion, you can see the current problem I'm facing here: https://github.com/tasts-robots/vulp/issues/27