upkie / vulp

Robot/simulation switch for the mjbots stack
Apache License 2.0
61 stars 4 forks source link

[feature] parameter to add extra URDFs #81

Closed ubgk closed 4 months ago

ubgk commented 4 months ago

This PR introduces a new parameter (i.e. a vector of strings) that can be used to specify additional URDFs to be loaded into simulation at launch time.

Closes #80.

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 7726630738


Changes Missing Coverage Covered Lines Changed/Added Lines %
vulp/actuation/BulletInterface.cpp 1 5 20.0%
<!-- Total: 1 5 20.0% -->
Totals Coverage Status
Change from base Build 7608961794: -0.2%
Covered Lines: 1760
Relevant Lines: 1968

💛 - Coveralls
stephane-caron commented 4 months ago

LGTM :+1:

If you feel so inclined you can also blast loading a ground plane URDF (removing the dependency on bazel::tools::cpp::runfiles::Runfiles) and pass the ground as an extra URDF in the Upkie spine. This would help with @pgraverdy's work where we cannot rely on Bazel runfiles any more.

ubgk commented 4 months ago

Circling back on this, can we just not set params.floor to false and pass the known ground plane URDF in params.extra_urdf_paths?

cc @pgraverdy

stephane-caron commented 4 months ago

Yes, and once that works, you can remove params.floor altogether :wink: