Remove unused find_plane_urdf function?

[stephane-caron]

This function is now unused in Vulp.

[coveralls]

Pull Request Test Coverage Report for Build 7904409601

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.4%) to 89.831%

---

Totals
Change from base Build 7843085997:	0.4%
Covered Lines:	1758
Relevant Lines:	1957

---

💛 - Coveralls

[stephane-caron]

@ubgk I believe this function is now unused. I guess we will also need to move the plane files from vulp/actuation/bullet/plane to somewhere close to the Bullet spine?

[stephane-caron]

Oh actually that may not be the smartest thing to do!

The initial direction was to stop relying on Bazel runfiles and Rlocation, since we now distribute Bullet spines with Upkie. But looking into the cache created by start_simulation.sh on Upkie 3.2.0 the runfiles are actually there:

./cache/bullet_spine.runfiles/vulp/vulp/actuation/bullet/plane/checker_blue.png
./cache/bullet_spine.runfiles/vulp/vulp/actuation/bullet/plane/plane.mtl
./cache/bullet_spine.runfiles/vulp/vulp/actuation/bullet/plane/plane.urdf
./cache/bullet_spine.runfiles/vulp/vulp/actuation/bullet/plane/plane.o

We are can use them even though we won't be running Bazel in the end.

This means we could keep some generic assets in Vulp, and access them from e.g. the Bullet spine via find_plane_urdf and similar functions. @ubgk what do you think?

If we go for this I'd advise we move the function to a clearer namespace, e.g. vulp::assets.

[stephane-caron]

If we go for this I'd advise we move the function to a clearer namespace, e.g. vulp::assets.

Adding to the idea: rather than re-invent a place to store environment meshes, we could integrate with mc_env_description. That project already has tables, chairs, ground planes and so forth.

[stephane-caron]

Closing this following https://github.com/upkie/vulp/pull/90