Unregister shared-memory management in Python spine interface

upkie / vulp

Robot/simulation switch for the mjbots stack

Apache License 2.0

61 stars 4 forks source link

Unregister shared-memory management in Python spine interface #89

Closed stephane-caron closed 4 months ago

stephane-caron commented 4 months ago

Closes https://github.com/upkie/vulp/issues/88

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 7905768739

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.466%

Totals
Change from base Build 7843085997:	0.0%
Covered Lines:	1758
Relevant Lines:	1965

💛 - Coveralls

stephane-caron commented 4 months ago

It is not straightforward to make a unit test for this issue. For instance the straightforward:

Create shared memory
Create spine
Destroy spine
Check that shared-memory file still exists

Does not fail even with the existing code, as the resource tracker won't free the shared memory in this instance (but it will when we run alongside a C++ spine).

Thus, no unit test in this PR :stuck_out_tongue:

I tested the change locally and the fix worked.