Remove leading slash from shared memory names

upkie / vulp

Robot/simulation switch for the mjbots stack

Apache License 2.0

61 stars 4 forks source link

Remove leading slash from shared memory names #94

Closed ubgk closed 1 month ago

ubgk commented 1 month ago

Fixes #92

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 8926440432

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.003%

Totals
Change from base Build 8910885060:	0.0%
Covered Lines:	1813
Relevant Lines:	2037

💛 - Coveralls

ubgk commented 1 month ago

I am not sure if this is a better approach than just changing all instances of /vulp to vulp.

This PR also adds some unexpected behaviour (that actually results from Python), but at least users don't need to worry about handling names differently in Python and C++, which is nice IMHO.

stephane-caron commented 1 month ago

Thank you for this fix :smiley: I think all tests go through, there is just a linter error. (You can also check linting locally with ./tools/bazelisk test --compilation_mode=fastbuild --config lint //....)