Observe base pose - Githubissues

upkie / vulp

Robot/simulation switch for the mjbots stack

Apache License 2.0

61 stars 4 forks source link

Observe base pose #98

Closed ubgk closed 1 month ago

ubgk commented 1 month ago

Should BulletInterface also log the base state?

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9276088929

Details

27 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 89.569%

Totals
Change from base Build 9269426067:	0.1%
Covered Lines:	1975
Relevant Lines:	2205

💛 - Coveralls

stephane-caron commented 1 month ago

Absolutely :+1: Can you add a unit test for it?

It will be similar to ObserveImuOrientation.

ubgk commented 1 month ago

Sure — I guess it would also make sense to cover the contact observations from the simulator as well. Right?

stephane-caron commented 1 month ago

Absolutely, and I completely forgot to do that when merging that feature :blush:

You don't need to worry about that part, though. I did it, so I test it: https://github.com/upkie/vulp/pull/99 (but if you are around feel free to review the PR :smiley:)

stephane-caron commented 1 month ago

A similar PR for inspiration: https://github.com/upkie/vulp/pull/102