Problem installing Git Credential Manager Core (Ubuntu 22.04.lts)

upleveled / system-setup

Set up a PERN development environment on Windows, macOS and Linux

28 stars 19 forks source link

Problem installing Git Credential Manager Core (Ubuntu 22.04.lts) #56

Closed CornaSn closed 4 months ago

CornaSn commented 8 months ago

https://github.com/upleveled/system-setup/blob/main/linux.md Tried this comment:

curl -L https://aka.ms/gcm/linux-install-source.sh | sh
git-credential-manager-core configure

This leads to:

$ curl -L https://aka.ms/gcm/linux-install-source.sh | sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  7233  100  7233    0     0  54705      0 --:--:-- --:--:-- --:--:-- 54705
This script will download, compile, and install Git Credential Manager to:

    /usr/local/bin

Git Credential Manager is licensed under the MIT License: https://aka.ms/gcm/license
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.
Please answer yes or no.
sh: 169: Syntax error: "fi" unexpected (expecting ";;")

With no chance to answer anything. Therefore the next step also doesn't work

karlhorky commented 8 months ago

Interesting, these are the official installation instructions

If you could re-report this over in their repository, that may be helpful for them. I would suggest:

mention that you were following the instructions "Install from source helper script"
mention your operating system
link to https://github.com/git-ecosystem/git-credential-manager/blob/release/docs/install.md#install-2

Maybe the alternative installation method to install the .deb file using dpkg would help?

CornaSn commented 8 months ago

Installing via package works.

But it seems you could install it via rpm so maybe this is a better approach:

https://github.com/microsoft/Git-Credential-Manager-for-Mac-and-Linux/blob/master/Install.md#installing-on-linux-using-rpm-recommended

sudo rpm --install git-credential-manager-2.0.4-1.noarch.rpm
git-credential-manager install

karlhorky commented 8 months ago

The link you posted above is to the old archived repo, which was archived in 2022 (check the notice at the top of the page)

karlhorky commented 8 months ago

So I would say probably:

[ ] the issue with installing from source should be reported in their repo
[ ] in the meantime, before it's fixed, we should change our System Setup instructions to use the .deb file instead

karlhorky commented 8 months ago

@CornaSn any news here? Did you manage to get it installed with the .deb file?

CornaSn commented 8 months ago

Yes I installed it with the .deb file and it worked

ProchaLu commented 4 months ago

There are 2 open issues for this problem.

Apparently, in this PR it should be fixed, released in version 2.5.0.

ProchaLu commented 4 months ago

Fixed in https://github.com/git-ecosystem/git-credential-manager/pull/1469 and released in version 2.5.0.