upleveled / system-setup

Set up a PERN development environment on Windows, macOS and Linux
28 stars 19 forks source link

Remove unnecessary useFlatConfig setting #78

Closed karlhorky closed 2 months ago

karlhorky commented 2 months ago

From the VS Code ESLint extension v3.0.5 prerelease notes:

Version 3.0.5 - pre-release

Support for the new ESLint flat config files has improved. The following changes have been implemented:

To use flat config files it is recommended to use ESLint version 8.57.0 or above. There is a new eslint.useFlatConfig setting which is honored by ESLint version 8.57.0 and above. If one of those versions is used, the extension adheres to the ESLint Flat config rollout plan. The setting has the same meaning as the environment variable ESLINT_USE_FLAT_CONFIG.

The experimental settings eslint.experimental.useFlatConfig is deprecated and should only be used for ESLint versions >= 8.21 < 8.57.0.

The 3.0.10 non-prerelease version of the extension with the new setting has been released as of 17 June 2024:

This was switched from eslint.experimental.useFlatConfig to eslint.useFlatConfig in other PRs elsewhere:

But in my testing (removing the eslint.useFlatConfig and eslint.experimental.useFlatConfig settings in settings.json and setting up a new Node.js project with the UpLeveled ESLint config), it appears that this config setting isn't required any more.

I've opened an issue here to clarify and request documentation about this: