search

uplift-ltd / nexus

https://nexus.uplift.ltd
MIT License
1 stars 1 forks source link

makeUrl has trouble with trailing slashes #413

Open pcraciunoiu opened 2 weeks ago

pcraciunoiu commented 2 weeks ago

This commit fixes an issue

https://github.com/Dermveda/learnskin-v3/pull/856/commits/6112f89a58998335734381840ccd3893e8653560

Including screenshot as well

image

Error: [types:check   ] src/components/common/AudioPlayer/LessonAudioPlayer.tsx(36,41): error TS2353: Object literal may only specify known properties, and 'course' does not exist in type '{ lesson: string | number; topicSlug: string | number; }'.

The line in question was

action: makeUrl(LESSON_URL, { course, lesson, topicSlug: topic }),
pcraciunoiu commented 2 weeks ago

@camflan wondering if this is an easy fix? Not urgent and happy to test it in the above context.