search

uploadcare / angular-uploadcare

Provides a directive for the Uploadcare widget.
MIT License
37 stars 16 forks source link

data-multiple don't working #7

Closed imevro closed 9 years ago

imevro commented 9 years ago

Probably because AngularJS changes data-multiple="multiple" to "multiple="multiple" and uploadcare widget receives incorrect option.

avsd commented 9 years ago

It seems to be unrelated to AngularJS changes. What exactly does not work?

Can you provide an example?

imevro commented 9 years ago

http://plnkr.co/edit/bAPqi7268lJJoKe7PyH5?p=preview

dmitry-mukhin commented 9 years ago

Is this expected Angular behavior? Seems like a weird err on it's part.

imevro commented 9 years ago

I update plunk: http://plnkr.co/edit/bAPqi7268lJJoKe7PyH5?p=preview As you see in DOM, data-multiple saved in div and input.

dmitry-mukhin commented 9 years ago

Well, the problem is with directive, not arbitrary DOM elements.

dmitry-mukhin commented 9 years ago

OK, I don't know angular at all, so please double check this.

  1. seems that this is a bug in Angular that happens when directive is "replacing"
  2. "replacing" is deprecated, so there is no hope that this will get fixed
  3. this seems to work: http://plnkr.co/edit/vByG5B4NOf8ye4KR0U1K?p=preview

If you can verify that this works for you too, we'll change directive behavior to not using replacement.

imevro commented 9 years ago

Now it working fine, thanks!