uploadcare / blocks

Stack-agnostic library for uploading, processing, and editing images on-the-fly
https://uploadcare.com/docs/file-uploader/
MIT License
61 stars 13 forks source link

fix(lr-config): normalize DOM property values #653

Closed nd0ut closed 2 months ago

nd0ut commented 2 months ago

Description

Fix for the bug found in https://github.com/uploadcare/blocks-examples/pull/29

The problem is that vue sets DOM properties with the value processing, like for attributes.

For example,

    <lr-config
      debug
    ></lr-config>

Here, a debug DOM property will have value of empty string (""). So seems like we should normalize also DOM property values too.

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The recent updates enhance configuration management by introducing new keys, functions, and clearer type definitions. Key additions include 'debug' settings and metadata handling functions. The changes streamline interactions and improve clarity in type usage, ensuring more robust and understandable configuration structures.

Changes

Files Changes Summary
.../Config/Config.js Updated key list, added new mapping functions.
.../Config/normalize...js Introduced new functions for metadata and locale overrides; updated type definitions.
types/exported.d.ts Renamed type for clarity and added descriptive comments.

🐇✨
In the realm of code, where the bits align,
A rabbit hopped through, making changes so fine.
New keys in the meadow, functions like dew,
Types clearer than ever, as the project grew.
Hop, hop, hooray, for the code now sings,
In a burrow of bytes, where the debug bell rings. 🎉


Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.