search

uploadcare / file-uploader

Stack-agnostic library for uploading, processing, and editing images on-the-fly
https://uploadcare.com/docs/file-uploader/
MIT License
61 stars 12 forks source link

localeDefinitionOverride not overriding on vue example #726

Open iqbaltawakkal opened 3 weeks ago

iqbaltawakkal commented 3 weeks ago

Describe the bug localeDefinitionOverride not override label in all file upload (minimal, regular, inline)

To Reproduce Steps to reproduce the behavior: I'm using file-uploader official example for vue

  1. Go to 'codesandbox'
  2. Scroll down to button upload
  3. Button title is not overridden

Expected behavior Button title should be 'Upload photos' instead of 'Upload files'

Screenshots image

Desktop (please complete the following information):

nd0ut commented 3 weeks ago

Hey @iqbaltawakkal,

Thanks for the feedback!

There was a mistake: the localeDefinitionOverride property should be assigned to the uc-config element instead of the uc-upload-ctx-provider. I have updated the Codesandbox, so it's fixed now.

iqbaltawakkal commented 3 weeks ago

hi @nd0ut thanks, I also submit PR for the composition one https://github.com/uploadcare/blocks-examples/pull/35

nd0ut commented 3 weeks ago

hi @nd0ut thanks, I also submit PR for the composition one uploadcare/blocks-examples#35

Merged. Thanks!