uploadcare / ngx-uploadcare-widget

Angular 2+ wrapper for Uploadcare Widget
MIT License
15 stars 10 forks source link

Prod build is still not happening at all :( #22

Closed Chethannp closed 4 years ago

Chethannp commented 6 years ago

2018_08_09_22_35_28_npm

Team, Please let us know if it is possible to resolve this by today else we will think about an alternative solutions as your updates are not helping us in any which ways and is killing most of our time in waiting for your inputs.

bautrukevich commented 6 years ago

@ZNick1982 please, look at this

Chethannp commented 6 years ago

Let me know what details you want. Fyi.. UcwidgetModule is still failing so tried follow methods posted in #10, This was at least working fine till last week not sure what happened now even this is failing :(

Chethannp commented 6 years ago

@ZNick1982 - Can you atleast tell me what needs to be done ??? #10 was working fine not sure what happened... Do you want to join a skype / hangouts call let me know, I think this interaction has now gone past 2+ months and we do not have a proper plugin from your team yet.

Chethannp commented 6 years ago

@ZNick1982 - can you respond to this thread asap please.

ZNick1982 commented 6 years ago

Hi @Chethannp . Just started to investigate this error. Will write back with updates.

Chethannp commented 6 years ago

@ZNick1982 - In the mean while can you please tell me how to import this into our project should I still follow #10 method?? I am using lazyloading.

Chethannp commented 6 years ago

I am doing it like this .. Followed #10 on commenting UcwidgetModule and UcWidgetCustomModule.

Created a shared module folder call ComponentsModule.

import { NgModule } from '@angular/core'; import { UcWidgetComponent } from 'ngx-uploadcare-widget'; import { ElasticHeaderDirective } from '../directives/elastic-header/elastic-header';

@NgModule({ declarations: [UcWidgetComponent, ElasticHeaderDirective], imports: [], exports: [UcWidgetComponent, ElasticHeaderDirective] }) export class ComponentsModule {}

Imported in my home page modules file import { NgModule } from '@angular/core'; import { IonicPageModule } from 'ionic-angular'; import { HomePage } from './home';

//Shared Module import { ComponentsModule } from '../../components/components.module'; import { ElasticHeaderModule } from "ionic2-elastic-header/dist";

@NgModule({ declarations: [ HomePage, ], imports: [ IonicPageModule.forChild(HomePage), ComponentsModule, ElasticHeaderModule ], }) export class HomePageModule {}

ZNick1982 commented 6 years ago

No, I think this steps will not help. This is another kind of error. Trying to figure out what exactly ionic wants.

Chethannp commented 6 years ago

ok. when you figure out and fix it please also walk me through steps to use it in my project pls pls pls. and by gods grace I hope you get the fix asap ,....!

ZNick1982 commented 6 years ago

@Chethannp Looks like I found the issue and fixed this in pr: https://github.com/uploadcare/ngx-uploadcare-widget/pull/23 Meanwhile pr on the review you can do following for your solution:

  1. Replace folder your_project/node_modules/ngx_uploadcare_widget/release with release from pr.
  2. Replace file your_project/node_modules/ngx_uploadcare_widget/package.json with same file from pr

Try to rebuild your solution.

Regarding the correct usage of widget.

  1. You need to to import module: import { UcWidgetModule } from 'ngx-uploadcare-widget'; and add this to your module as in example:
    @NgModule({
    declarations: [
    MyApp,
    AboutPage,
    ContactPage,
    HomePage,
    TabsPage
    ],
    imports: [
    BrowserModule,
    IonicModule.forRoot(MyApp),
    UcWidgetModule
    ],
    bootstrap: [IonicApp],
    entryComponents: [
    MyApp,
    AboutPage,
    ContactPage,
    HomePage,
    TabsPage
    ],
    providers: [
    StatusBar,
    SplashScreen,
    {provide: ErrorHandler, useClass: IonicErrorHandler}
    ]
    })
    export class AppModule {}
  2. Just use the component in the your app:
    
    <ion-header>
    <ion-navbar>
    <ion-title>
      About
    </ion-title>
    </ion-navbar>
    </ion-header>

Hope this helps.
Chethannp commented 6 years ago

I am trying this now. @ZNick1982 - Can you please send me the copy or zip of this folder not able to take it from the commit.

ZNick1982 commented 6 years ago

Ok, Please write me back with results.

Chethannp commented 6 years ago

Just downloaded the branch v_1.1.3_typings_fix and trying it out on a fresh project. In the meanwhile can you please look into the safari issue

Chethannp commented 6 years ago

@ZNick1982 - It is still failing..

2018_08_09_22_35_28_npm

Should I create a shared module declare it there and then import it in the lazy loaded list page?

Fyi: This is the command I am using ionic cordova build --release --prod android can you try this with the sample project that I had given you earlier ? You are checking this right?

ZNick1982 commented 6 years ago

let me check on my laptop

ZNick1982 commented 6 years ago

Looks like you did not replace the package.json from the pr. Since the typings still looks to ngx-uploadcare-widget/release/src/ folder.

Chethannp commented 6 years ago

No I did a clone of the entire branch to my local.

2018_08_09_22_35_28_npm

ZNick1982 commented 6 years ago

Can you please check again. Since the typing should use release folder: image

Chethannp commented 6 years ago

I am doing it again.

Chethannp commented 6 years ago

I think the issue is resolved. Will any how confirm in 2 hours.

Chethannp commented 6 years ago

@ZNick1982 - it is still failing

2

2018_08_10_18_23_04_package json_app_visual_studio_code

ZNick1982 commented 6 years ago

@Chethannp Its still not version from pr. Can you please check it again? The typings field should be: "typings": "release/index.d.ts",

Chethannp commented 6 years ago

Sorry had a script internally in my code which was running npm install.. sorry my bad its working now..!

ZNick1982 commented 6 years ago

@Chethannp We just released new version 1.1.3 of library in npm. Can you run npm update on your projects. And try to rebuild.

Chethannp commented 6 years ago

Doing it now.

Chethannp commented 6 years ago

Fantastic work @ZNick1982 - It fixed the build issue!!!! Thanks a lot man.

Chethannp commented 6 years ago

Will not bug guys anymore if you can help me with the safari issue. The widget is not seen in safari browser instead white screen is displayed may be css's are not being applied or something could you please try to reproduce this on your system.

ZNick1982 commented 6 years ago

@Chethannp Thanks! I can check Safari issue on the next week just after I've got my Mac back. Now I work on Windows laptop.

bautrukevich commented 6 years ago

@Chethannp on Safari MacOS? Or iOS? Can we close this issue?

bautrukevich commented 6 years ago

On Safari MacOS demo works fine

bautrukevich commented 6 years ago

Also, I check demo on iOS Simulator in Safari iOS — works fine.

bautrukevich commented 6 years ago

@Chethannp please, provide your example and let's see.