Closed emerth closed 2 years ago
hugovk
commented
2 years ago When making a PR, by default it goes to the upstream.
But you can choose to make it against another fork instead.
At the "Open a pull request" page, click on the "base repository: python-pillow/Pillow" button:
Then start typing "uploadcare" into the filter and select this fork:
And in the preview you should hopefully only see your new commits.
emerth
commented
2 years ago I see. Thank you! I will send along a pull request this weekend.
homm
commented
2 years ago The build instructions for Windows do not pull in libdeflate nor the ztsd library. They need to be installed and added to the setup.py script.
I believe this is not related to Pillow-SIMD. Please send this changes to the upstream https://github.com/python-pillow/Pillow
What did you do?
Tried to build on Window 10 using VS2019.
What did you expect to happen?
Successful build.
What actually happened?
Build failed in link stage. Missing various ZSTD and libdeflate functions.
What are your OS, Python and Pillow versions?
The build instructions for Windows do not pull in libdeflate nor the ztsd library. They need to be installed and added to the setup.py script.
I tried to send a pull request with a change to winbuild/README.md, but it landed at https://github.com/python-pillow/Pillow, not uploadcare. Seemed like a request to merge all of uploadcare/pillow-simd, which they very reasonably declined to do. Very embarrassing.
Is this an update you are interested in? I can try to send a new pull req, or just post the changes here... they are pretty small.