search

uploadcare / uploadcare-java

Java API client that handles uploads and further operations with files by wrapping Uploadcare Upload and REST APIs.
https://uploadcare.com
Apache License 2.0
6 stars 13 forks source link

Add support for InputStreams, updated deprecated code #17

Closed Arteneko closed 5 years ago

Arteneko commented 5 years ago

From #16

I implemented support for InputStreams in the FileUploader, but a question arise for me: Wouldn't a FileUploader API redesign be better ?

There's a mess between 3 constructors, and a lot of unused private attributes, and I think that redesigning it to instead have some kind of helper/builder could help avoid that. Something that'd build the Part or add itself to the built part instead of having a lot of constructors.

I also had to update the Maven target version to 1.6 since the 1.5 version was not supported anymore.

dmitry-mukhin commented 5 years ago

👍 great job

dmitry-mukhin commented 5 years ago

@IvanDelsinne can you add tests for new use case?

Arteneko commented 5 years ago

I don't really know how to test this new feature, I'm gonna have to think about that.

Arteneko commented 5 years ago

Thanks for your work