search

uploadcare / uploadcare-ruby

Ruby API client that handles uploads and further operations with files by wrapping Uploadcare Upload and REST APIs.
https://uploadcare.com
MIT License
39 stars 28 forks source link

Update locations where Dry::Monads structure has changed #133

Closed geeosh closed 10 months ago

geeosh commented 10 months ago

Success and Failure are now part of Dry::Monads::Result.

Description

When the gem's Dry::Monads dependency was upgraded to v1.6, there were a few places that missed upgrading the Dry::Monads::Success and Dry::Monads::Failure to their new location, as a class namespaced under Dry::Monads::Result

It is interesting that the tests did not fail, we first discovered it when trying to run document conversion using this gem version. Some that are passing but should have failed are document_conversion_client_spec.rb.

kraft001 commented 10 months ago

@geeosh Thank you for your contribution! The update will be included in the next release

geeosh commented 10 months ago

@kraft001 you're welcome - thanks.