uploadcare / uploadcare-ruby

Ruby API client that handles uploads and further operations with files by wrapping Uploadcare Upload and REST APIs.
https://uploadcare.com
MIT License
39 stars 28 forks source link

Suppport all options for file copying #25

Closed vizvamitra closed 7 years ago

vizvamitra commented 7 years ago

Addresses #22

@dmitry-mukhin I've added two separate file copying methods, #internal_copy and #external_copy. I'll rename them when you deside on propper names and before merging this PR.


Note that new methods get their optional arguments as an options hash, which is inconsistent with common practice for this library, but provides some benefits:

I need your confirmation for that.


I'll add deprecation of File#copy and a fix to use pub/priv keys from Travis env vars in specs in 2 separate PRs.