vizvamitra
commented
7 years ago @dmitry-mukhin I see two ways to do so:
-
We limit max input size to 100. One
#store_files/#delete_filescall - one request. Return value = api response.#store_files/#delete_filesmethods remain simple, which is good.In this case, storage/deletion of FileList becames problematic because we can't tell how much files are there in total before they all will be loaded. To handle this we can add separate methods,
#storeand#delete, to FileList class. They'll use#store_filesand#delete_filesinternaly, which will be called multiple times if there is more than 100 files in a FileList. To provide user with API responses, we can make this methods to acceps a block in which we'll pass each response:
list = api.file_list
list.delete do |response| # this block will be called for each internat #delete_files request
if response['problems'].any?
# ...
end
end- We add the same block as above to
#store_filesand#delete_filesmethods, passing each API response into it. In this case those methods became smart:
uuids # => # array of > 100 uuids
problems = {}
api.delete_files(uuids) do |response| # will be called (uuids.size / 100 + 1) @times
problems.merge!(response['problems']) if response['problems'].any?
end
dmitry-mukhin
dm
closes #21
I've added two new methods:
Uploadcare::Api#store_filesUploadcare::Api#delete_filesBoth of them accept either an array containing UUIDs/
Uploadcare::Api::Files or anUploadcare::Api::FileList.Notes
Please note the changes in lib/uploadcare/rest/connections/api_connection.rb. The
DELETE /files/storage/endpoint accepts UUIDs of files to be deleted. It accepts them in the form of a json array in request's body. As far as I know, there is no way to send an unamed array in a url-encoded format (which we use now), so I was forced to change the request params encoding strategy tojson. Tests are passing, so I think this won't cause any issues.