search

uploadcare / uploadcare-ruby

Ruby API client that handles uploads and further operations with files by wrapping Uploadcare Upload and REST APIs.
https://uploadcare.com
MIT License
39 stars 28 forks source link

Enables automatic storing when uploading file #35

Closed Meekohi closed 7 years ago

Meekohi commented 7 years ago

One implementation detail is that the API will only "not store" only if the store param is missing or store:0. store:'false' will not work (the API will evaluate that to true and store anyway)

vizvamitra commented 7 years ago

@Meekohi thanks for your contribution.

I'm currently working on adding support of UPLOADCARE_STORE flag (see upload api docs). This change will include a fix to your problem. WIP branch can be found here. I beleve I'll finish it in a couple of days

dmitry-mukhin commented 7 years ago

@Meekohi, @vizvamitra's changes seem to be more fundamental. can you check if his branch works for you?

Meekohi commented 7 years ago

Works for me -- looks like a good more general solution in case there are more flags in the future.

dmitry-mukhin commented 7 years ago

closes in favour of #36