search

uploadcare / uploadcare-ruby

Ruby API client that handles uploads and further operations with files by wrapping Uploadcare Upload and REST APIs.
https://uploadcare.com
MIT License
39 stars 28 forks source link

Improvements on file spec #45

Closed lidimayra closed 7 years ago

lidimayra commented 7 years ago

1 - Remove old should syntax from _filespec

** Similar to what had already been done in #42 with _parserspec

Before: should01

After: should02

2 - Replace instance variables defined in before block with lets

Usage of instance variable is an anti-pattern. Usage of lets are more efficient. Ref: http://www.betterspecs.org/#let

Before: instance-variables

After: instance-variable02

dmitry-mukhin commented 7 years ago

cool, thanks! @vizvamitra please take a look.