search

uploadcare / uploadcare-ruby

Ruby API client that handles uploads and further operations with files by wrapping Uploadcare Upload and REST APIs.
https://uploadcare.com
MIT License
39 stars 28 forks source link

Add SecureSignature generation for signed uploads #60

Closed bananatron closed 3 years ago

bananatron commented 5 years ago

I suspect some way of having this library generate signatures in the format required for signed uploads might be a good idea (maybe a ruby example in documentation might be good enough).

I'm sure there are a lot of things wrong on this PR (not sure if tests are even running & adding activesupport) and I'm new to Uploadcare so feel free to throw this away if you think it's needless.

👍

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.0%) to 99.028% when pulling 60d1de78fbf7117ae819dda5ee2d449363706687 on bananatron:secure-signature into f78e510af0b2ec0e4135e12d444b7793b0a1e75c on uploadcare:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.0%) to 99.028% when pulling 60d1de78fbf7117ae819dda5ee2d449363706687 on bananatron:secure-signature into f78e510af0b2ec0e4135e12d444b7793b0a1e75c on uploadcare:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.0%) to 99.028% when pulling 60d1de78fbf7117ae819dda5ee2d449363706687 on bananatron:secure-signature into f78e510af0b2ec0e4135e12d444b7793b0a1e75c on uploadcare:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.0%) to 99.028% when pulling 60d1de78fbf7117ae819dda5ee2d449363706687 on bananatron:secure-signature into f78e510af0b2ec0e4135e12d444b7793b0a1e75c on uploadcare:master.

dmitry-mukhin commented 5 years ago

we need to add signature generation to the lib, but I don't see an implementation here :(

bananatron commented 5 years ago

Ok let me know if there's a way to make this better or just close it, I'm using similar code to do it for signature generation in my app right now.