search

uploadcare / uploadcare-ruby

Ruby API client that handles uploads and further operations with files by wrapping Uploadcare Upload and REST APIs.
https://uploadcare.com
MIT License
39 stars 28 forks source link

Bump faraday versions #64

Closed Draiken closed 3 years ago

Draiken commented 4 years ago

Description

The current Faraday dependency is extremely old (8 years ago) and very restrictive.

I've relaxed the version requirements and ran the tests without issues.

Version 3 is still in development and unfortunately forcing anyone that uses the gem to downgrade Faraday to 0.9 is not a great solution. Because of that I believe we can relax those dependencies without issues.

Changelog Stub

Checklist

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.5%) to 99.507% when pulling 1e92df1f0b963e6a7745e1c71cbcd2ba794996c2 on Draiken:bump-faraday into f78e510af0b2ec0e4135e12d444b7793b0a1e75c on uploadcare:master.

Draiken commented 4 years ago

Crap, I think to support Ruby 1.9 we'd also have to lock json version to ~> 1 and that'd use a very vulnerable JSON version from 2015 too. And you cannot really release a minor patch changing these versions without breaking apps on Ruby 1.9. I imagine it'd have to be a major version upgrade.

I guess I will have to use a fork until version 3 is out :disappointed: