Closed dalizard closed 2 years ago
Nice man!
I was about to work on this too. Good job! 🦾
<3
@rsedykh we need to figure out if we want to drop support for rubies <= 2.7
@dmitry-mukhin Hmm, it's interesting that the <= 2.7 specs are failing -- I don't see how this is related to my changes 🤔
@dalizard I assume it's due to dry-configurable
reqs
@dmitry-mukhin You are spot on! The dry-configurable gem has introduced the default
keyword argument and deprecated the positional default argument in version 0.13.0, which also requires Ruby >= 2.6.0. In essence there is no way to use the default
keyword argument if Ruby is < 2.6.0. There are different ways to approach and solve this -- my idea is to maintain Ruby backwards compatibility but also not simply silence warning messages.
Bumping to get it merged.
Description
With version 0.13.0 of the dry-configurable gem, the default value for a setting provided as a positional argument is deprecated. The
default:
keyword argument should be used instead.This pull request fixes #97.
Checklist