search

uploadcare / uploadcare-widget

Uploadcare Widget, an ultimate tool for HTML5 file upload supporting multiple file upload, drag&drop, validation by file size/file extension/MIME file type, progress bar for file uploads, image preview.
https://uploadcare.com/products/file_uploader/
BSD 2-Clause "Simplified" License
227 stars 102 forks source link

Effects don't show up in multiple mode when importing english-only version #786

Closed henrymyers closed 3 years ago

henrymyers commented 4 years ago

Description

When importing uploadcare.lang.en.js from uploadcare-widget, the effects tab no longer works with multiple file mode.

Steps to reproduce

Dev Setup

  1. Import uploadcare.lang.en.js
  2. Import uploadcare-widget-tab-effects
  3. Register the effects tab (uploadcare.registerTab("preview", uploadcareTabEffects);)
  4. Set data-multiple="true"

User Steps

  1. Click on the Uploadcare button
  2. Upload multiple images
  3. Click on any image in your list of uploads
  4. Notice the missing effects

See CodeSandbox example for an immediate repro https://codesandbox.io/s/uploadcare-multiple-effects-en-only-6nuri

Expected result

Just like with the default uploadcare.js file, the effects tab should appear when clicking on any image in your multiples list.

Actual result

It only opens the cropper

Environment

See the CodeSandbox example for a working repro setup.

henrymyers commented 4 years ago

@jeetiss I noticed this when working on the locale settings

jeetiss commented 4 years ago

yes 😞 this happen because effects-tab import and patch different widget bundle https://github.com/uploadcare/uploadcare-widget-tab-effects/blob/a9308b7b4743a1c4fae5044397196710a056271b/src/index.js#L1

we need eng only version for effects-tab , i'm trying to do it on next week

henrymyers commented 4 years ago

Sounds good 👍 Anyway, I can just import the default bundle in the meantime. Just wanted to flag this.

henrymyers commented 3 years ago

@jeetiss Any news on an english-only version of the uploadcare-widget-tab-effects?

henrymyers commented 3 years ago

Fixed by PR 41

nd0ut commented 3 years ago

@henrymyers Thank you so much for your help. It was released under uploadcare-widget-tab-effects@1.5.0 version.