search

upmc-enterprises / registry-creds

Allow for AWS ECR, Google Registry, & Azure Container Registry credentials to be refreshed inside your Kubernetes cluster via ImagePullSecrets
Other
344 stars 124 forks source link

Replace ReplicationController with Deployment #77

Closed reegnz closed 4 years ago

reegnz commented 5 years ago

As the official k8s docs state:

Note: A Deployment that configures a ReplicaSet is now the recommended way to set up replication.

https://kubernetes.io/docs/concepts/workloads/controllers/replicationcontroller/

Fixes #76

stevesloka commented 4 years ago

Thanks for the PR @reegnz! I took your commit and fixed up the merge conflicts in #84.

reegnz commented 4 years ago

Cool, thanks!