search

upmc-enterprises / registry-creds

Allow for AWS ECR, Google Registry, & Azure Container Registry credentials to be refreshed inside your Kubernetes cluster via ImagePullSecrets
Other
344 stars 124 forks source link

Newly published registry-creds image (1.10) does not contain ACR (Azure) support #85

Closed karolz-ms closed 4 years ago

karolz-ms commented 4 years ago

Repro steps:

  1. Install the registry-creds controller following standard instructions
  2. Deploy the controller
  3. Attach a shell to the controller container
  4. Run strings -n 9 registry-creds | grep acrClient

Expected: a bunch of strings that have 'acrClient' in them Actual: nothing

For comparison, this is the result of running the same command on zpkarol/registry-creds:1.10 image that I have build for testing (it is available from Docker Hub):

karolz:~/ strings -n 9 registry-creds | grep acrClient
acrClient
*main.acrClient
main.acrClient.getAuthToken
main.(*acrClient).getAuthToken
main.acrClient.getAuthToken.stkobj
go.itab.main.acrClient,main.acrInterface
main.acrClient.getAuthToken
main.(*acrClient).getAuthToken

Looks like incorrect (old) binary was included in the 1.10 image? @stevesloka could you take a look? Thanks!

karolz-ms commented 4 years ago

Hey @stevesloka @oliverspryn do you guys have a timeframe for investigating this issue?

I double-checked the image again and I am pretty sure the binary inside does not have support for Azure 😞

stevesloka commented 4 years ago

Let me take a look this afternoon @karolz-ms

stevesloka commented 4 years ago

Hey @karolz-ms can you re-pull the image? I just rebuild it all again. Thanks!

karolz-ms commented 4 years ago

It works! 😌 Many thanks, @stevesloka