upmin / upmin-admin-ruby

Framework for creating powerful admin backends with minimal effort in Ruby on Rails.
MIT License
754 stars 66 forks source link

Denial of Service Vulnerability #110

Closed jimmynguyc closed 10 years ago

jimmynguyc commented 10 years ago

Was running my own version of Upmin::ModelsController and saw this vulnerability on my project CodeClimate scan.

https://github.com/upmin/upmin-admin-ruby/blob/master/app/controllers/upmin/models_controller.rb#L132

jimmynguyc commented 10 years ago

Made a pull request https://github.com/upmin/upmin-admin-ruby/pull/109

mbrookes commented 10 years ago

Probably not a major issue, as UA would normally be restricted to trusted users, but still good practice. Merged.

jimmynguyc commented 10 years ago

Aye .. it's just me being anal :p