upmin / upmin-admin-ruby

Framework for creating powerful admin backends with minimal effort in Ruby on Rails.
MIT License
755 stars 66 forks source link

use tr instead of gsub when possible #140

Open acrogenesis opened 9 years ago

acrogenesis commented 9 years ago

tr is over 5x faster than gsub. Also tr is the concise idiomatic method call you do for that kind of things

joncalhoun commented 9 years ago

Let me make sure this is still valid and I'll try to get it merged. Sorry for the massive delay - haven't touched this gem in a bit due to work and other things eating up all my time.

acrogenesis commented 8 years ago

@joncalhoun if you want I can remake this PR.