search

upnotes-io / react-todo

A generic todo list componet for react. This is being used in an electron based app: https://upnotes.io
8 stars 41 forks source link

Add new todo item on pressing enter in between todo list rows #24

Open kamalkishor1991 opened 1 year ago

kamalkishor1991 commented 1 year ago

Pressing enter for creating new row works for the first item but it does not work for rest of the rows. https://upnotes-io.github.io/react-todo/

  1. If cursor is in the middle the line should get split into 2 with dividing the text into 2 lines and cursor remains in the next line.
  2. By pressing enter in the end of the line should cause new row to be created in the next line and the curser shoud be in the next line.
  3. By pressing enter in the begining of the line should cause the row to be created at the top and the cursor should remain in the current line.

Basically 2ed and 3ed points are special conditions to the first point so if first usecase is implemented correctally the 2ed and 3ed should automatically work.

yeswanthannadata commented 1 year ago

Hi @kamalkishor1991, I want to work on this. Please assign it to me.

serickson67 commented 1 year ago

Hi @kamalkishor1991 - I also wouldn't mind giving this issue a try. Please assign it to me if you are okay with me working on it. Thanks!

yeswanthannadata commented 1 year ago

26 @kamalkishor1991 @bhujoshi

bhujoshi commented 1 year ago

@yeswanthannadata Thanks. Added comments on PR.

yeswanthannadata commented 1 year ago

@bhujoshi Thanks. I will check and update

raj5036 commented 1 year ago

Hi @kamalkishor1991 , can I work on this?

kamalkishor1991 commented 1 year ago

@raj5036 sure. assigning to you.

gkasoff commented 1 year ago

Hi @kamalkishor1991 I would like to give this a go, could you please assign to me?

gkasoff commented 1 year ago

Hi @kamalkishor1991 I would like to give this a go, could you please assign to me?

Hey @kamalkishor1991 I finished. Did not fork the repository so am receiving an error when trying the command git push -u origin my-branch-name.

The error I am seeing is remote: Permission to upnotes-io/react-todo.git denied to gkasoff. fatal: unable to access 'https://github.com/upnotes-io/react-todo.git/': The requested URL returned error: 403

I generated a SSH key and successfully authenticated, but did not have any luck.

How should I proceed?

kamalkishor1991 commented 1 year ago

can you check git remote -v in your repository? I think your origin is set to https://github.com/upnotes-io/react-todo.git instead of the the fork. https://stackoverflow.com/questions/42830557/git-remote-add-origin-vs-remote-set-url-origin You should change the origin to your fork.

gkasoff commented 1 year ago

can you check git remote -v in your repository? I think your origin is set to https://github.com/upnotes-io/react-todo.git instead of the the fork. https://stackoverflow.com/questions/42830557/git-remote-add-origin-vs-remote-set-url-origin You should change the origin to your fork.

Thank you for helping with that. PR sent.

gkasoff commented 1 year ago

Hi @kamalkishor1991 can you review my PR request?