User should be able to navigate using up and down arrow keys in todo items.

upnotes-io / react-todo

A generic todo list componet for react. This is being used in an electron based app: https://upnotes.io

8 stars 41 forks source link

User should be able to navigate using up and down arrow keys in todo items. #30

Closed bhujoshi closed 1 year ago

serickson67 commented 1 year ago

I'd like to work on this, will you assign it to me?

serickson67 commented 1 year ago

Thanks, I'm on it!

serickson67 commented 1 year ago

Hi - I've made some good progress on this, but have some questions about how you would like certain cases to behave:

Do you want the up arrow key to allow the cursor to move just between the created ToDoItems or should it also allow you to arrow up into the 'Add Item' text field?
Do you want the up arrow/down arrow to be circular? Meaning, if the cursor is at the top of the list of items, and you hit the up arrow it will move the cursor to the bottom? And vice versa for the down arrow at the bottom of the list of items.

kamalkishor1991 commented 1 year ago

@serickson67 great. Thanks

It should move to add item also.
No I don't think circular make sense.

serickson67 commented 1 year ago

Please review my pull request: #41

serickson67 commented 1 year ago

Hey - I linked my pull request above, but it doesn't seem linked to this issue. Sorry, I'm fairly new to contributing to open-source projects, could you tell me how I should have linked it?

serickson67 commented 1 year ago

Hey - please don't forget to review my pull request with the updates - and also, can you please add the hacktoberfest label to this issue and the pull request so I can get credit there? I appreciate it. @kamalkishor1991

kamalkishor1991 commented 1 year ago

@serickson67 thanks for helping out with this. Merged the PR and closed the ticket.