upnotes-io / react-todo

A generic todo list componet for react. This is being used in an electron based app: https://upnotes.io
8 stars 41 forks source link

full dark mode #34

Open mohdhaider07 opened 1 year ago

mohdhaider07 commented 1 year ago

make want to make it also dark image

UI is not matching with dark mode

Thxmxs commented 1 year ago

I'd like to work on this, could you assign it to me?

partha7978 commented 1 year ago

Could you please assign it to me?

Anurag-NURA commented 1 year ago

I have a question. Can multiple people work on a single issue simultaneously

kamalkishor1991 commented 1 year ago

@Anurag-NURA yes it is possible.

  1. If the original assigner is not responding, someone else can pick up the issue by commenting on it.
    • Please comment on the issue you are planning to pick by tagging the original assigner and wait for at least 24 hours for someone to respond. If someone does not respond in 24 hours you can pick up the issue.
  2. If someone is already working on it you can ask them about the progress and if you can also work on some part of the issue.
  3. If the issue is small enough and you can solve it quickly and you can directally create a PR.
Anurag-NURA commented 1 year ago

I would like to work on this project, @kamalkishor1991 could you please assign it to me?

Anurag-NURA commented 1 year ago

Should I make a Dark mode folder inside "./src/common/Todo" so that I can import it later in the root file ?

kamalkishor1991 commented 1 year ago

@Anurag-NURA please create a pull request with your changes. We can provide feedback in the pull request.

Anurag-NURA commented 1 year ago

it is almost complete. I will soon create a pull request

dinesh-14 commented 1 year ago

@Anurag-NURA Is this done ? @kamalkishor1991 can you assign this to me if not done already ?

Anurag-NURA commented 1 year ago

@Anurag-NURA Is this done ? @kamalkishor1991 can you assign this to me if not done already ?

I completed the dark mode, @kamalkishor1991 said to make an external prop for the user so that it's upto him to either use the dark mode feature or not. I am not sure how to do that in typescript .

dankokonate commented 1 year ago

can you assign me please

Justinsinotte commented 1 month ago

Is this finished?

antriksh16b commented 1 week ago

Please assign this to me I have already implemented this on my theme Changer project.